I'm not sure exactly how you wanted your script to work, but here's my attempt at a more structured version of your code.

Take notice that I've use 'eq' instead of '=' when comparing the values. '=' is the assignment operator, it doesn't compare two strings. Don't feel bad though, it's one of the biggest gotchas, and _everybody_ has done it at some point.

You also need to chomp the value from STDIN, as this will always have a new line ('\n') char at the end, and comparing $string eq "whatever" won't work because of the extra character 

print("Type R to re-enter the values or Type E to exit:\n");
my @values;
while (<STDIN>) {

    my $value = $_;
    chomp($value);

    last if $value eq 'E';
    
    if ($value eq 'R') {
        @values = ();
        print "values have been cleared\n";
    } else {
        push(@values, $value);
    }
}

print join(',', @values) . "\n";

[download]

In reply to Re^2: Advice on goto usage? by reasonablekeith
in thread Advice on goto usage? by imperl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.