You should be using strict. I think $q.="$key, "; should be $query.="$key, ";

update: and you're creating a new lexical variable $query within the if ($action eq ..., which goes out of scope.

my $query; if ($action eq 'Problem Submit') $query = "INSERT INTO Ticket_Data ("; for $key ( keys %ORA_MAPPING ) { my $value = $ORA_MAPPING{$key}; next if $key eq "Data_id"; $query.=" $value, "; # or did you really mean $key here? }
Also note that you should be careful if you build queries from external/dynamic input. Use placeholders if you can, and DBI->quote otherwise.


In reply to Re: Dynamic query generation by Joost
in thread Dynamic query generation by chanakya

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.