I don't have access to my ISP's server logs but want to have some idea of who's visiting my website, this script mail visitors info.
I want excluse my own IP, so I add one line, $ips (IP addresses I want to ignore), for my IP:
unless ($ENV{REMOTE_ADDR} =~ /$ips/) {
..... }
Also I add use strict; use warning;
Is the changes I have make correct? 
 
#!/usr/bin/perl
use strict;
use warning;

$sendmail_path='/usr/lib/sendmail';

$to_address='my@domain.com';

$ips = '127.0.0.1';

#DONT CHANGE ANYTHING BELOW THIS LINE

unless ($ENV{REMOTE_ADDR} =~ /$ips/) { 

if (length($ENV{HTTP_X_FORWARDED_FOR})>1) { $xf=$ENV{HTTP_X_FORWARDED_
+FOR}; }
else { $xf='NULL'; }
$ra=$ENV{REMOTE_ADDR}; @numbs=split(/\./, $ra);
$address=pack("C4", @numbs); $gothostbyaddr=gethostbyaddr($address, 2)
+;
$gt=gmtime; $head=$ENV{REMOTE_ADDR};
@tl=(85,78,73,46,68,69); ($gothostbyaddr) && ($head=$gothostbyaddr); 
if (length($ENV{QUERY_STRING})>1) { $reff=$ENV{QUERY_STRING}; } else
{$reff=$ENV{HTTP_REFERER};
$reff=~s/%([a-fA-F0-9][a-fA-F0-9])/pack("C", hex($1))/eg;
} $head.=" $reff"; 
$from_address="a".$to_address;
open(MH,"|$sendmail_path -t");
print MH "To: $to_address\nFrom: $from_address";
print MH "\n";
print MH "Subject: Visitor Info $head\n\nHTTP_REFERER $reff";

print MH "\n";

print MH "DNS $gothostbyaddr\nIP $ENV{REMOTE_ADDR}";

print MH "\n";

print MH "BROWSER $ENV{HTTP_USER_AGENT}\nWHEN $gt GMT";

print MH "\n";

print MH "FORWARDED_FOR $xf";

print MH "\n";

print MH "APPS $ENV{HTTP_ACCEPT}\n\n";

print "\n";

close MH;

print "Content-type: image/x-xbitmap\n\n";
print "#define name_width 1";
print "\n";
print "#define name_height 1";

print "\n";

print "static char name_bits[] = { 0x04 };";
print "\n";

}

[download]

Edited by Arunbear: Changed title from 'Adjusting one feature', as per Monastery guidelines

In reply to Code Review of Visitor Logging Script by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.