Could could make this code a lot cleaner. Notably, that mess of splits and data assignments at the top, using `ls` when you should be using readdir, and scoping of variables.

Here's what i came up with after five minutes: 
sub PRINT_INFO {
    my ($netid, $sitename, $sector) = @_;
    my $DAILY_HEAD = "Date       Total";
 
    $,="\t";    #Output Field Separator
 
    my $report_type = 'Daily Totals';
    my $MARKET = 'PHL';
 
    my $DAILY_PATH = "/data1/$MARKET/reports";
    my $BUSY_PATH = "/data1/$MARKET/bhreports";
    my $PKD_PATH = "/data1/$MARKET/pkdreports";
    my $MISC_PATH = "/data1/$MARKET/miscreports";
    my $MDG_PATH = "/data1/$MARKET/mdgreports";
 
    my $cellname = "$sitename Sector $sector";
    my $search_string = "\Q$netid";
 
    print "$cellname\n";
 
    opendir DIR, $DAILYPATH;
    my @all_readable_files = grep { ($_ ne '.') && ($_ ne '..') && ($_
+ !~ /\.Z//) } readdir DIR;
    closedir DIR;
 
    print "$DAILY_HEAD\n";
 
    my $file;
    foreach $file (@all_readable_files) {
        my $date = substr ($file, 0 , (index $file, '_'));
 
        open(FILE, "$DAILY_PATH/$file");
        @DATA=<FILE>;
        @result = grep { (index $_, $search_string) > -1 } @DATA;
        for ( $i = 0; $i <= $#results; $i++ ) {
            my $info = (split('    ', $result[$i]))[7];
            print $date , $info . "\n";
        }
        close FILE;
    }
}

[download]

In reply to Re: Re: Re: Foreach Complications by kilinrax
in thread Foreach Complications by ImpalaSS

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.