This is just rewriting your code with a basic few improvements, just to make it easier to work with. Note - your SQL statement is still borked. 
sub getips {
    my ( $j, $vlan ) = @_;

    my $name = "ips" . $j;

    my ($sth, $dbh, %ips, $i, @iparray);

    my $dbh = DBI->connect('DBI:ODBC:Servers', { RaiseError => 1, Auto
+Commit => 0 });

    my $sth = $dbh->prepare( <<__END_SQL__ );
SELECT IPs.octet1
      ,IPs.octet2
      ,IPs.octet3
      ,IPs.octet4
  FROM IPs LEFT OUTER JOIN StaticIPs
        ON IPs.Octet1 = StaticIPs.octet1
       AND IPs.Octet2 = StaticIPs.octet2
       AND IPs.Octet3 = StaticIPs.octet3
       AND IPs.Octet4 = StaticIPs.octet4
 WHERE StaticIPs.octet1 IS NULL
   AND IPs.VLAN = ?
__END_SQL__

    $sth->execute( $vlan );

    my @ips;
    $sth->bind_columns( \( $ips[0], $ips[1], $ips[2], $ips[3] ) );
    $sth->{'ChopBlanks'} = 1;

    my @iparray;
    while ($sth->fetch) {
       next unless $ips[0]; 

       push @iparray, join '.', @ips;
    }

    $sth->finish();
    $dbh->disconnect();

    print scrolling_list(
        -class   => 'df',
        -name    => $name,
        -size    => 1,
        -values  => [@iparray],
        -default => $iparray[-1]
    );
}

[download]
  • In general, if you think something isn't in Perl, try it out, because it usually is. :-)
  • "What is the sound of Perl? Is it not the sound of a wall that people have stopped banging their heads against?"

In reply to Re: Lookahead algorithm for IP subroutine by dragonchild
in thread Lookahead algorithm for IP subroutine by hok_si_la

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.