I write web apps that usually require/allow the uploading of files (pdf, jpg, doc, cvs). I have lately been using the following (just a snippet for comparison reasons):

$filename = $sourcepath = $query->upload($file);
$filename =~ /([\w. -]+)$/i;
$filename = $1;
$filename =~ s/ /_/g;    

my $size = $ENV{CONTENT_LENGTH};
if ($size > $max) { 
   return ($filename,"File is too large to upload.",$size);
}
    
open(OUTPUT, ">$path/$filename") or return ($filename, "Cannot open '$
+filename'. Contact Webmaster"); ; 
binmode($filename);
binmode(OUTPUT);
    
while( read($sourcepath, $buffer, 64*2**10) ) {
   print OUTPUT $buffer;
}
    
close(OUTPUT);

[download]

However, I just saw this in a recent unrelated node. 

my $upload_filehandle = $query->upload("filename");

open UPLOADFILE, ">$upload_dir/$filename";

binmode UPLOADFILE;

while ( <$upload_filehandle> )
 {
   print UPLOADFILE;
 }

close UPLOADFILE;

[download]

What are the advantages and disadvantages of both? The last one sure looks cleaner--do I need all the stuff in the former? General comments? Thanks.


—Brad
"The important work of moving the world forward does not wait to be done by perfect men." George Eliot

In reply to File uploading methods compared by bradcathey

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.