Nice, but don't forget the first rule of a capturing m// - test for success before using $1...
while (<DATA>) {
next unless m/(\d+)\D+(\d+)/; # or warn && next, or die
$min = $1 if $1 < $min;
$max = $2 if $2 > $max;
}
Also, rather than imposing an artificial limit on min (and max), what about addind a definedness check?
$min = $1 if ( ! defined( $min ) || ( $1 < $min ) );
$max = $2 if ( ! defined( $max ) || ( $1 > $max ) );
I'll grant that the since this doesn't handle negative numbers (yet) anyway, max is likely fine the way it is.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.