First, use RaiseError since you are not consistent about checking errstr (and in fact are checking a $dbh errstr on a $sth call).

Second, USE PLACEHOLDERS! (I yell because it's been said so many times on perlmonks it's hard to believe you haven't seen it).

Third, read the DBI docs about the rows() method - it rarely does what you want with a select statement. Instead, test the return value of the execute statement (but read the DBI docs about what execute returns).

update and bind_columns should come before an execute, not after (my bad) (thought it's hard to tell what you are wanting to do with it). Also look up MySQL's replace command if you are going to be updating a row (no need to check first).

I really recommend you read the docs and some tutorials on DBI since your mistakes are DBI mistakes, not SQL or MySQL mistakes (in this case)

In reply to Re: MySQL logic by jZed
in thread MySQL logic by sulfericacid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.