index beats everything else I have tried, including various regexps. The fastest I have found is

my @o; my $o = -1; push @o, $o while ($o = index($s, 'a', $o+1)) > -1;

E.g.:

use strict; use warnings; use Benchmark 'cmpthese'; srand( 0 ); my $s = join '', map chr(97+int(rand(26))), 1..100_000; cmpthese( -1, { windex => \&windex, windex_1 => \&windex_1, wregex => \&wregex, } ); sub windex { my @o; my $o = -1; while ( ( $o = index( $s, 'a', $o+1 )) > -1 ) { push @o, $o } return; } sub windex_1 { my @o; my $o = -1; push @o, $o while ($o = index($s, 'a', $o+1)) > -1; return; } sub wregex { my @o; $s =~ m/a(?{ push @o, pos() - 1 })(?!)/; return; } __END__ Rate wregex windex windex_1 wregex 204/s -- -37% -39% windex 324/s 59% -- -4% windex_1 336/s 65% 4% --

Updates: Way too many. Reversed my first reversal (I'd inadvertently introduced a bug in wregex that resulted in only one match taking place, which made it look faster). Minor tweaks to wregex (eliminated the unneccessary /g, and removed a stray 0; in the (?{}) code.

the lowliest monk


In reply to Re: Producing a list of offsets efficiently by tlm
in thread Producing a list of offsets efficiently by BrowserUk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.