For one thing, a hash with 20 keys is not really very big at all. Another thing is you shouldn't be iterating on the hash keys and matching with eq. The hash can do near O(1) lookups by itself -- that's one of the major reasons to use a hash. You are completely eliminating that advantage, and you're making the code much more complicated than it needs to be. The entire inside of your while loop can be replaced with this:

chomp; if (exists $myhash{$_}) { $myhash{$_}->(); } else { $myhash{default}->(); }

Update: in case it wasn't clear from my reply, I suggest you stick with the hash-based approach. It should work fine for this kind of thing.


In reply to Re: CLI using hashes by revdiablo
in thread CLI using hashes by bahadur

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.