A number of folks ( gawatkins, Tanktalus, GrandFather ) have mentioned that part of their reason for prefering on-screen review is that it provides them with syntax highlighting.

This isn't an issue for me, as I have access to a color printer, and a text editor that will print its syntax highlighting, not only display it on the screen. (and even when I print to the non-color printer, I can make out differences in shades, although if I try to print pages 2-up at 9pt, some of the 'colors' become illegible from dithering)

Others ( kirbyk, tlm, and anonymous ) have mentioned working with others, or in a team during the review. As I'm two time zones away from the next closest programmer on my current project, the best I have for collaboration is IM, and pushing files around through CVS and/or email.

I think my big question in this whole thing is what to do people consider to be 'review' ...

Much of what people are talking about (actively making changes, or making sure that the changes have the desired results), I would consider to be debugging, or in some degards, tuning. When I hear 'review', I think of a much more higher level thing -- attempting to look over the logical flow of code, and trying to understand it, often to determine how we can refactor it. Sometimes, it's trying to make the code more modular, or trying to remove redundancies. Other times, it's just me trying to understand how someone else wrote their code. (eg, trying to understand how SOAP::Lite works, so I can override the serializer to do what I needed).

So, are we all even discusing the same sorts of activities here?

In reply to Re: Code Review - What Medium? by jhourcle
in thread Code Review - What Medium? by ghenry

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.