That's another reason why it's simpler to have just binary operations at each level (instead of a longer sequence of same-precedence operations). ;)

Consider the generic outline: 

lower_prec_expr : higher_prec_expr lower_prec_op lower_prec_expr
                | higher_prec expr

[download]
The problem is that you want your parse to give different semantic values for the different branches. If you take the 2nd branch, it's just a "pass-through" of the semantic value and you don't want to construct a new arrayref around it. If you take the first branch where there is actually an operation, you need to construct an arrayref with the appropriate things.

You've combined both of these branches into one production in the grammar like this: 

lower_prec_expr : higher_prec_expr (lower_prec_op lower_prec_expr)(s?)
                      { [ "put stuff in arrayref" ] }

[download]
So now you're putting things inside an arrayref even in the "pass-through" case, where there is no operator at this point in the parse.

To fix this, put a conditional in your semantic rule to distinguish these cases, i.e: 

lower_prec_expr : higher_prec_expr (lower_prec_op lower_prec_expr)(s?)
                      { @{$item[2]} ? [ ... ] : $item[1] }

[download]
That's kinda nasty. Alternatively, have two different productions explicitly in the grammar: 
lower_prec_expr : higher_prec_expr (lower_prec_op lower_prec_expr)(s)
                      { [ ... ] }
                | higher_prec_expr

[download]
I.e, if there *are* operators here (no question mark on the (s) quantifier), we build an arrayref for the semantic value with the first branch. Otherwise, the second branch has no semantic rule, so it's just a "pass-through" of the semantic value and does not add layers of arrayref.

The latter is probably the best choice. Just change the (s?)'s to (s)'s and add the other alternation to the grammar.

blokhead

In reply to Re^3: Order of Precedence in Parse::RecDescent grammar by blokhead
in thread Order of Precedence in Parse::RecDescent grammar by suaveant

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.