In all the myriad ways of reviewing code that I have gone through (including not doing it), my favorite is the formal code review we did at MCI.

The author would publish the code (at that time it was C) to a central spot. Then the review facilitator (usuallly someone from the QA or PM group) would schedule the review, and point all the reviewers to the central code. The reviewers were to be given at least 3 days to review the code and prepare their questions/ objections. On the day of the review, the facilitator would poll the invitees to see if they had completed their reviews, and if enough had (at least 3 developers besides the author) the review went on as scheduled.

At the review, an overhead with the code in question, as well as printouts of the code were provided, and the facilitator asked if there were any questions or objections to the code. The questions and the objections were recorded and the author was given a change to explain or rebut. At the end of the review, a go/no-go decision for the code to proceed to implementation was requested, and if consensus was not reached, the date for the next review was discussed.

This was a huge improvement over the previous way we had done them, which was for a bunch of people to get together in a conference room and have the code read to them line by line.

In reply to Re: Code Review - What Medium? by poqui
in thread Code Review - What Medium? by ghenry

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.