Moving the comma from the end of the first digit group match to the start of the second digit group tidys things up a little:
  /^\$?(\d{1,3}(,\d{3})*|\d+)(\.\d\d)?$/
my @Strings = ( '$3,023,123.34', '9,876,453', '123456.78', "4,33,234.34", '$1.234', "abc", "1,0000.00" ); my $Payment; foreach $Payment (@Strings) { if ($Payment =~ /^\$?(\d{1,3}(,\d{3})*|\d+)(\.\d\d)?$/) {print "Match: $Payment\n";} else {print "Fail: $Payment\n";} } Output: Match: $3,023,123.34 Match: 9,876,453 Match: 123456.78 Fail: 4,33,234.34 Fail: $1.234 Fail: abc Fail: 1,0000.00 Match: 199999.99
Update: Fix the ReadMore :-)
Raise your eyes and look out of the rut.

In reply to Re: Regular Expression Currency Check by GrandFather
in thread Regular Expression Currency Check by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.