Ryanc, I can't tell you exactly what your problem is but I am guessing your logic is choking here with too many ands and ors. I tidied things up a bit below and my brain swims trying to understand exactly what is being anded and ored in various places. Try getting this cleaner and I bet it will start working.

net::ftp is probably catching the error just fine, but some other combination of your logic is returning true. Remember, FALSE or TRUE or FALSE is... true. 

    if (
        ( $ftp->login($data->{'login'}, $data->{'pw'}) 
          or
          $log->logwarn("upload_file: xqe $data->{'id'}, ", $ftp->mess
+age)
        ) 
        &&
        ($ftp->binary or $log->logwarn("upload_file: xqe $data->{'id'}
+, ", $ftp->message)) 
        &&
        ($ftp->cwd($data->{'remote_dir'}) 
        or
        $log->logwarn("upload_file: xqe $data->{'id'}, ",
        $ftp->message)) 
        &&
        ($ftp->put($to_upload) or
        $log->logwarn("upload_file: xqe $data->{'id'}, ",
        $ftp->message)) &&
        ($ftp->quit)
      ) {
        return 1;
    }
    else {
        $log->error("upload_file: xqe $data->{'id'}, " .
                    "upload failed for $to_upload");
        return undef;
    }

[download]

In reply to Re: Net::FTP not catching errors, my fault? by tphyahoo
in thread [solved] Net::FTP not catching errors, my fault? by ryanc

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.