As has been pointed out, if logwarn returns true, then all the ftp commands are going to be run regardless (as each condition checked by the and's are going to be true).

As you print the same log info each time, you could try something like the following, which avoids the constant line-noise log writing. 

if ($ftp->login($data->{'login'}, $data->{'pw'}) and
    $ftp->binary                                 and
    $ftp->cwd($data->{'remote_dir'})             and
    $ftp->put($to_upload)                        and
    $ftp->quit) {
    return 1;
} else {
    $log->logwarn("upload_file: xqe $data->{'id'}, ", $ftp->message)
    $log->error("upload_file: xqe $data->{'id'}, " . "upload failed fo
+r $to_upload");
    return undef;
}

[download]
---
my name's not Keith, and I'm not reasonable.

In reply to Re^3: Net::FTP not catching errors, my fault? by reasonablekeith
in thread [solved] Net::FTP not catching errors, my fault? by ryanc

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.