You can avoid modifying $_ within the sub, by doing the initialization of $hash_ref in a BEGIN block:

{ my $hash_ref; BEGIN { while (<DATA>){ chomp; my ($str, $num) = split /\|/; $hash_ref->{$str} = $num; } } sub get_number{ my ($num) = @_; return $hash_ref->{$num}; } }
As a small bonus, the sub doesn't need to perform a test that would have been true only once.

Update: In light of hv's comments below, I conclude that, in this case at least, saving the while (<DATA>) is not worth all the fuss and worry over $_. Hence in the revision below, the loop does not use $_.

{ my $hash_ref; BEGIN { while (defined (my $line = <DATA>)){ chomp $line; my ($str, $num) = split /\|/, $line; $hash_ref->{$str} = $num; } } sub get_number{ my ($num) = @_; return $hash_ref->{$num}; } }

the lowliest monk


In reply to Re: Closure producing 'Modification of read-only value' error by tlm
in thread Closure producing 'Modification of read-only value' error by wfsp

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.