I have been dillegently working on my first module, while testing it - I noticed a discrepancy in the values it returns depending on how its called. Here is my module code
use strict; use IO::Socket::INET; use Socket; use Carp; package mship; ############## sub connection ############## { my $IP = shift; my $TCP_PORT = shift; my ( $ipadd, $port_name, $remote_name ); $ipadd = Socket::inet_aton($IP) or croak "$IP is not valid\n"; $port_name = getservbyport($TCP_PORT, 'tcp') or $port_name = "unknown"; $remote_name = gethostbyaddr( $ipadd, 2 ) or croak "Unable to resolve hostname for $IP\n"; my %stats = ( 'IP' => $IP, 'PORT' => $TCP_PORT, 'port_name' => $port_name, 'remote_name' => $remote_name, 'status' => &stat($IP, $TCP_PORT) ); print "sub connection port = $TCP_PORT IP = $IP\n"; return %stats or croak "unable to return the value of \%stats\n";; } ############# sub stat ############# { ( $ip, $tcp_port ) = @_; my $status = "Up"; my $sock = IO::Socket::INET ->new( Timeout => 5, PeerAddr => $ip, PeerPort => $tcp_port, Proto => 'tcp' ) or $status = "Down"; return ($status, $tcp_port, $ip); croak "Unable to return the value of \$status\n"; } 1;
and this is how im calling it
#!/usr/bin/perl -w use strict; require "mship.pm"; my %stats = mship::connection('xxx.19.208.27', '9101'); while (my ($key, $value) = each(%stats)) { print "$key = $value\n"; } my $status = mship::stat->('xxx.19.208.27', '9101'); print "\nStatus is $status\n";
and here are my results
port_name = unknown remote_name = r_dairy.xxx.com status = Up IP = xxx.19.208.27 PORT = 9101 Status is Down
if I use port 80 in my test both calls report up.

any ideas, as to where I should look?

UPDATE
Im an idiot. I was making changes to a local file called mship.pm and mship.pm was installed. Here is the code - and it works fine...
use strict; use IO::Socket::INET; use Socket; package mship; ############## sub connection ############## { my $IP = shift; my $TCP_PORT = shift; my ( $ipadd, $port_name, $remote_name ); $ipadd = Socket::inet_aton($IP) or die "$IP is not valid\n"; $port_name = getservbyport($TCP_PORT, 'tcp') or $port_name = "unknown"; $remote_name = gethostbyaddr( $ipadd, 2 ) or die "Unable to resolve hostname for $IP\n"; my %stats = ( 'IP' => $IP, 'PORT' => $TCP_PORT, 'port_name' => $port_name, 'remote_name' => $remote_name, 'status' => &mstat($IP, $TCP_PORT) ); print "sub connection port = $TCP_PORT IP = $IP\n"; return %stats or die "unable to return the value of \%stats\n";; } ############# sub mstat ############# { my ( $ip, $tcp_port ) = @_; my $status = "Up"; my $sock = IO::Socket::INET ->new( Timeout => 5, PeerAddr => $ip, PeerPort => $tcp_port, Proto => 'tcp' ) or $status = "Down"; return ($status); die "Unable to return the value of \$status\n"; } 1;
Ted
--
"That which we persist in doing becomes easier, not that the task itself has become easier, but that our ability to perform it has improved."
  --Ralph Waldo Emerson

In reply to different results from the same sub by tcf03

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.