Your module doesn't even compile. How could it have given that output?
Below, I
- BUG: Changed mship::stat->(...) to mship::stat(...). (This is the answer to your question.)
- BUG: Moved package mship;. croak was being imported into the wrong namespace.
- BUG: Added missing my in stat.
- BUG: Removed the croaks after the returns. return never fails, so the croaks would never be reached.
- Renamed stat to accepts_conn to avoid confusion with the builtin function stat.
- Changed to require "mship.pm"; to use mship;
- Returned a better result from accepts_conn (formerly stat). (Save the conversion to strings for when it's time to print. Work with true and false until then.)
- Uppercase variable names are usually constants. Changed the case of connection's arguments.
- Simplified $port_name = A or $port_name = B; to $port_name = A or B;.
- Added spacing so I could see what I was doing.
- Is confused as to the purpose of connection.
use strict;
package mship;
use IO::Socket::INET;
use Socket;
use Carp;
##############
sub connection
##############
{
my ( $ip, $tcp_port ) = @_;
my $ipadd = Socket::inet_aton($IP) or
croak "$IP is not valid\n";
my $port_name = getservbyport($TCP_PORT, 'tcp') or "unknown";
my $remote_name = gethostbyaddr( $ipadd, 2 ) or
croak "Unable to resolve hostname for $IP\n";
my %stats = (
'ip' => $ip,
'port' => $tcp_port,
'port_name' => $port_name,
'remote_name' => $remote_name,
'status' => accepts_conn($IP, $TCP_PORT) ? "Up" : "Down"
);
print "sub connection port = $TCP_PORT IP = $IP\n";
return %stats;
}
#############
sub accepts_conn
#############
{
my ( $ip, $tcp_port ) = @_;
my $sock = IO::Socket::INET ->new(
Timeout => 5,
PeerAddr => $ip,
PeerPort => $tcp_port,
Proto => 'tcp',
);
return $sock ? 1 : 0;
}
1;
#!/usr/bin/perl -w
use strict;
use mship;
my %stats = mship::connection('xxx.19.208.27', '9101');
while (my ($key, $value) = each(%stats))
{
print "$key = $value\n";
}
print "\n";
my $status = mship::accepts_conn('xxx.19.208.27', '9101') ? "Up" : "Do
+wn";
print("Status: $status\n");
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.