simonwilliams,

  1.    if ($#bids){...}
    does what you mean, but it doesn't really say what you mean. For that, you should say
       if (@bids > 1){ ... };
    i.e., if @bids contains more bids than one, then ...
  2.   for (my $i=1; $i<scalar(@bids); $i++) { ... }
    could be written ...
      for (my $i=1; $i < @bids; $i++) { ... }
    ... without any change in meaning. @bids is being evaluated in a scalar context. No need to say scalar() explicitly.
  3. Let me oversimplify your problem, and you can build on that. You want to choose the highest bid, excluding your own from consideration (always the first bid), and print only the highest bid. 
    my $highest;
if (@bids > 1){
    for (my $i = 1; $i < @bids; $i++) {
        my ($alias, 
            $email, 
            $bid, 
            $time, 
            $add1, 
            $add2, 
            $add3, 
            $oqty, 
            $soldqty) = read_bid($bids[$i]);
        $highest = $bid > $highest ? $bid : $highest;
    }
    print "Highest bid: $highest\n";
}

    [download]

mkmcconn

In reply to Re^3: everyauction script error bidding errors by mkmcconn
in thread everyauction script error bidding errors by simonwilliams

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.