If it works and it is readable, I wouldn't be too concerned about a few for loops. That said, I'd probably do two things: use hash slices (see perldata) instead of all of the individual $data{key} = $_->key; statements, and pull the guts of the for ( @info ) loop into a subroutine (since you use it twice). For example (untested):

for ( @info ) { push( @loop_data, get_info( $_ ) ); } sub get_info { my ( $info ) = @_; my $sth = $obj->DBI->Replies->sql_count; $sth->execute( $info->id ); my $info->count = ( $sth->fetchrow_array )[0]; my @keys = qw( author content title id date count ); my %data; @data{ @keys } = @$info{ @keys }; return \%data; }

Note: I changed $r to $info->count to clean up the hash slice. Update: Corrected $count to $info->count.

HTH, and congrats on getting it working. That's the first step. :-)


In reply to Re: My excessive and redundant code<333 by bobf
in thread My excessive and redundant code<333 by stonecolddevin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.