May I recommend an editor (other than notepad) which may have improved indenting facilities?

The syntax error is your friend, if it tells you that ]; is bad, then it probably is. If not, then something near it is.

If you were to indent your code in a more clear fashion your code might look like this:

#!/usr/bin/perl -w

use PDL;

$matrixfile = $ARGV[0];

open(MATRIX, "$matrixfile") ||
  die "Error: Can't open $matrixfile file for reading: $!\n";

@matrix = <MATRIX>;

for(my $i = 0; $i < @matrix; $i ++)
{
    $a = substr($matrix[$i], 0, 5);
    $b = substr($matrix[$i], 6, 5);
    $c = substr($matrix[$i], 12, 5);
    $d = substr($matrix[$i], 18, 5);
    $cd = substr($matrix[$i], 24, 5);
    
    my $dmat = pdl [
                    [ $a, $b, $c, $d],
                    
                }

    ];

[download]

Instantly you'd see that maybe a closing bracket was missing off the my $dmat = pdl [ ... ]; command. And that the final curly brace should probably be swapped with the square bracket the syntax error is complaining about.

Update: posted solution here:

#!/usr/bin/perl -w
use PDL;

$matrixfile = $ARGV[0];

open(MATRIX, "$matrixfile") ||
  die "Error: Can't open $matrixfile file for reading: $!\n";

@matrix = <MATRIX>;

for(my $i = 0; $i < @matrix; $i ++)
{
    $a = substr($matrix[$i], 0, 5);
    $b = substr($matrix[$i], 6, 5);
    $c = substr($matrix[$i], 12, 5);
    $d = substr($matrix[$i], 18, 5);
    $cd = substr($matrix[$i], 24, 5);
    
    my $dmat = pdl [
                    [ $a, $b, $c, $d],
                    ]
};

[download]

In reply to Re: creating matrices for PDL module by monarch
in thread creating matrices for PDL module by Angharad

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.