Critisms: You're doing a describe on the table for each query which is inefficient (and not portable), your code doesn't handle any interesting queries (only select by ID specific values), and you should probably use $fetchrow_hashref instead of transforming the result of $fetchrow_array to a hash.

This has all been done before, also by me, and I learned a lot from it, but the main thing I learned is that doing it right takes a whole lot of effort. :-)

Take a look at Class::DBI and Class::DBI::Autoloader for a framework that tries to do it right (and mostly succeeds in my opinion). There is a list of different implementations here.


In reply to Re: easier to get data from a database by Joost
in thread easier to get data from a database by rsiedl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.