1) Your || has too high precedence.
open ACCESS, ">> $log" || die "Cannot open $log: $!";
is equivalent to
open ACCESS, (">> $log" || die "Cannot open $log: $!");
which is equivalent to
open ACCESS, ">> $log";
Instead, use
open(ACCESS, ">> $log") || die "Cannot open $log: $!";
or
open ACCESS, ">> $log" or die "Cannot open $log: $!";

2) You don't check if chdir succeeded.

3) The three argument form of open is safer.

4) Using lexicals for filehandles is cleaner.

5) The following is easier to read and less error-prone:

my $log = $file;
$log =~ s#^.*/##;
$log =~ s#\.[^.]$##;
$log .= '.log';

[download]

6) join might be a better choice instead of all those string concatenations.

7) Finally, you could eliminate the chdir as follows:

$log = "/perl/web/examscores/$courselocation/access/$log";

[download]

Fixed code:

    my $clocktime = localtime;

    my $log = $file;
    $log =~ s#^.*/##;
    $log =~ s#\.[^.]$##;
    $log = "/perl/web/examscores/$courselocation/access/$log.log";

    open(my $access, '>>', $log)
       or die("Cannot open $log: $!\n");

    print $access (
       join(' ',
          $idinput,
          $lname,
          $fname,
          $clocktime,
          $useripaddress,
          $time,
       ), "\n");

    close($access);

[download]

By the way, localtime returns a string with spaces in it (in scalar contect).

In reply to Re: Cann't create a file by ikegami
in thread Cann't create a file by chriso

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.