First, a stylistic issue: Rather than having
$path mean two different things within the same span of code, it might be better write
my $size = -s "$path/$file";
...
print `cat $path/file`;
instead of appending
$file to
$path.
Next, a robustness issue: Are you really, really sure that "$path/$file" exists? Better to test first and issue an appropriate error message, rather than hiding an error message from cat in the purported pfd stream.
Lastly, a very minor performance issue: why use cat when you can do the same in process with a few extra lines of Perl?
if ( open(PDF, "<$file/$path" ) {
print "Content-type: application/pdf\n";
print "Content-length: ", -s "$file/$path", "\n";
print "\n";
print <PDF>;
close(PDF);
}
else {
print "Content-type: text/plain\n\n";
print "$file/$path: $!\n";
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.