system("rm $ERRORFILE") if -e $ERRORFILE;

Why not unlink?

Why not File::Find?

Why no -w?

Why don't you check to see if the dir is already mounted before mounting?

Why don't you use Archive::Tar/Compress::Zlib/etc.. for compressing.

And, personally, when I have something on a cron and use any type of config file, I like to make sure that noone is editing it when the script starts to run. I usually use a shell script which is called by cron that is something like:

#!/bin/sh r=`ps -eaf | grep <name of script> | grep -v grep | grep -v vi` if [ $? -eq 1 ] then /run/the/script else sleep 10 /re/run/this/script fi

This way, if the script is running, it is being edited, or if the conf file is being used (assumming foo.pl has foo.conf, and you have <name of script> as 'foo') it will wait. YMMV.

But, much better than your original. It is always exciting to see yourself (and others) progress. Good show!

Cheers,
KM


In reply to Re: Evolution of a Perl Programmer (new backup script) by KM
in thread Evolution of a Perl Programmer (new backup script) by reyjrar

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.