First, prepare() is not a statement handle method, it's a database handle one. Apart from that, your way seems appropriate for what you want to do. In the TIMTOWTDI philosophy, you could set up the SQL statement and placeholders in the conditional and execute at the end. Something along the lines of

my ($sql, @placeholders);
if (@rows == 0)
{
  $sql = qq{SELECT 1};
  @placeholders = ($svr1, $ap1, $in);
}
else
{
  $sql = qq{SELECT 2};
  @placeholders = ($svr1, $ap);
}

my $sth = $dbh->prepare($sql);
$sth->execute(@placeholders);

[download]

Looks more wordy, but that's how I usually like to do it.

Update: I had a comment for @rows == "0", but apparently perl is smart enough to DWIM and guess the correct context, never producing any warning or some such, whatever the case may be (@rows eq "0", @rows eq 0 and @rows == 0 all work).

In reply to Re: Using If statement to set DBI prepare by Fang
in thread Using If statement to set DBI prepare by dtharby

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.