What is the ($files >= 1) bit for? You're putting a string (the filename) into a numeric context here? Are your filenames numeric or are you trying to test to see if $files is non-empty? If it's the latter, consider just doing if ($files) { ... }, but realize that your while statement above that would have done that test itself, or else you wouldn't be inside the loop! The plural itself is kind of a misnomer as well, but it's not hurting anything.

In addition, expanding upon your 'while' test, if you have a filename of 0 (zero), your loop will exit, even if there are more files to be read. Consider checking for defined-ness: while (defined ($file = readdir(DIR))) { ... }


In reply to Re: File list by date by Fastolfe
in thread File list by date by rasmus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.