Do not use bare word filehandles.
Bare word filehandles have worked fine since perl1.000, where the way 99% of the code used filehandles until 5.6.0, and are still used in the majority of the code.

Just stating "don't use bare word filehandles" without any motivation at all doesn't serve anybody.

use the three argument form of open: open(my $fh, '<', $file)
Again, no motivation why to not use a construct which has worked fine for almost 20 years. Just because there's a different way of doing things isn't reason enough to critize the old use.

If you are doing an exact match... perhaps you want to use substr instead of a regex. (Would be much faster).
Really? How about this benchmark:
use Benchmark 'cmpthese'; our $orig = "a" x 20; $orig .= "<!-- TBROWS //-->"; $orig .= "a" x 20; $orig .= "<!-- TBROWS //-->"; $orig .= "a" x 20; cmpthese(-1, { 's///' => 'my $c = $orig; $c =~ {<!-- TBROWS //-->}{XXXX}g;', substr => 'my $c = $orig; while ((my $i = index($c, "<!-- TBROWS //-->")) > -1 +) { substr($c, $i, 17) = "XXXX"; }' }); __END__ Rate substr s/// substr 240498/s -- -37% s/// 381869/s 59% --

In reply to Re^2: Sub Return Value Help by Anonymous Monk
in thread Sub Return Value Help by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.