Fellow Monasterians;

I'm trying to bring old code into conformity, in particular the way I call subroutines. I'm trying to convert any instances of $somecall to somecall() preserving any passed values in parens.

while (<DATA>) {
   chomp;
   $_ =~ s/^&(\w+)([\(\)]*)/$1()/;
   print "$_\n";
}

__DATA__
&foobar
&foobar()
foobar()
&foobar("asdf")

[download]

which prints:

foobar()
foobar()
foobar()
foobar()"asdf")

[download]

Close, but no cigar. So, tried:

while (<DATA>) {
   chomp;
   $_ =~ s/^(&)(\w+(\([\"\'\$\w]*\))?)(\(\))$/$2()/;
   print "$_\n";
}

[download]

which printed:

&foobar
foobar()
foobar()
&foobar("asdf")

[download]

Again, close, but my &'s are back. What am I missing? Thanks!

UPDATE: Pasted in correct #2 expression (thanks davidrw)


—Brad
"The important work of moving the world forward does not wait to be done by perfect men." George Eliot

In reply to Regex to strip, keep, or add—depending by bradcathey

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.