I expect that the corresponding nested if..else construct would be even more baffling. The weakness here is in the negated and chopped-up logic, not the trinary op. I'll make a first cut at rewriting it: 

my $send_now_button =
    $auth{'SEND'} && $status==1 && $approved && !$send_now ?
    qq( ...blah blah ...) : '';

[download]
Not nested, you can use it now ;-)

I think I had an easier time decyphering the (well-formatted!) nested trinary than I would have a similarly built if statement.

Update: Just for fun, here's thing I'm slanging, formatted the best I know how, 

my $send_now_button;
if ( !$auth{'SEND'} ) {
    $send_now_button = '';
}
else {
    if ( $status != 1 ) {
        $send_now_button = '';
    }
    else {
        if ( $approved ) {
            if ( $send_now ) {
                $send_now_button = '';
            }
            else {
                $send_now_button = qq( ...blah blah ...);
            }
        }
        else {
            if ( $send_now ) {
                $send_now_button = '';
            }
            else {
                $send_now_button = '';
            }
        }
    }
}

[download]
Noisy, ain't it? That maybe does even better than the trinary version at pointing out how ludicrous the logic is, but IMO trinary makes it easier to see how to fix it. I didn't even bring elsif to the table :-))

After Compline,
Zaxo

In reply to Re^2: Ternary operators: a hinderance, not a help by Zaxo
in thread Ternary operators: a hinderance, not a help by Tanalis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.