Two coding comments...

The inclusion of $junk on the LHS of the split assignment is unnecesary. Take it out, remove the third argument to split on the RHS, and split will automatically split the string into no more than 15 pieces (one more than the number of lvalues on the left) and discard the extra piece.

    next if $op_target eq '' or ! defined $op_target;

[download]
That condition is backwards; if $op_target is not defined, it will always be equal to ''. To avoid a warning; the defined test should come first.


And one efficiency comment...

You may get a small measure of improved efficiency by combining the calls to sprintf with the call to print. For example: 

printf "$user_ip_addr $username - " .
       "[%02d/$months[$date_mon]/$century%02d:%08d $utc_offset] " .
       qq{"$op_name $op_target" $service_status_code $bytes_sent "-" "
+-"\n},
       $date_dd, $date_year, $time;

[download]

In reply to Re: Efficiency revisited by chipmunk
in thread Efficiency revisited by tekniko

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.