I applied the following patch on the pmdev server, 

--- NodeBase.pm.orig    2005-08-21 11:22:05.250000000 +0200
+++ NodeBase.pm    2005-08-21 18:33:38.859375000 +0200
@@ -2031,9 +2031,18 @@
 
     #you're always approved if it's yourself...
 
-    foreach my $approveduser (@{ $this->selectNodegroupFlat($NODE) })
+    foreach my $node (@{ $this->selectNodegroupFlat($NODE) })
     {
-        return 1 if ($user_id == $this->getId($approveduser));
+        return 1 if ($user_id == $this->getId($node));
+        if ($node->{rulecode}) {
+            my $res=eval $node->{rulecode};
+            if ($@) {
+                #logit danno
+                Everything::printLog("Rule error in $node->{node_id}:
+$@");
+                # return 0; # should this happen?
+            }
+            return $res if defined $res;
+        }
     }
 
     return 0;

[download]

and created a new dbtable and nodetype 'rule', with the following structure: 

CREATE TABLE rule (
 rule_id int(11) NOT NULL auto_increment,
 rulecode text,
 PRIMARY KEY  (rule_id)
) TYPE=MyISAM

[download]

An 'edit' display page and a 'display' display page cribbed from htmlcode, along with a tweak of patachable fields completed my modifications. All together they allow arbitrary rules to be added to usergroups, which when encountered by isApproved() will be executed and used to control the access.

Advantages: Very simple change to code with far reaching effects, very flexible. Disadvantages: requires usergroup wrapper even if you only want a rule. Requires added table.

IMO this would be a good addition to PM. I was thinking that the documentation for the nodes would be provided by the 'display' page showing a sitedoclet if one existed, possibly via a generalized 'add a sitedoclet to this' mechanism that could be reused elsewhere.

---
$world=~s/war/peace/g

In reply to Adding a 'rule' system to isApproved() by demerphq

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.