Ever thought about (ab)using interpolation and the list-seperator variable to simplify things visually? Or perhaps some rudimentary checking of expected arguments?

  sub insert {      # Untested, but you get the idea ...

      my $dbh     = shift or warn("No database handle"), return;
      my $table   = shift or warn("No table given"),     return;
      my @columns = @_    or warn("No columns given"),   return;

      my $sql;
      {
          local $"    = ","; # interpolation voodoo :-)

          my @values  = ("?") x @columns;
          $sql        = "INSERT INTO $table (@columns) VALUES (@values)"; # s/my //
      }

      $dbh->prepare($sql) or die("Couldn't prepare $sql " . $dbh->errstr);

  }

    --k.

Update: per extremely below, because they've got a point. :-)


In reply to Re: SQL INSERT creator by Kanji
in thread SQL INSERT creator by boo_radley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.