A few suggestions:
Once you have fetched the page you could simply and blindly write it over the old version to the disk. That would be cheaper than calculating a checksum, esp. because you have to download the page twice (your function does not return the fetched data). So i would at least alter your code.
return ($md5, \$response);
Also, you do not return (but warn) when when the fetch fails. I didn't check what happens when you
md5_hexing an undef value and what the code returns. It should return undef to indicate the failure to the caller. So, even if your code works, it would be simply clearer when you explicitly return undef when the fetch fails.
unless ($response->is_success)
{
warn "Error while getting ", $response->request->uri,
" -- ", $response->status_line, "\nAborting";
return;
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.