Wow, that's quite a knee-jerk reaction there.

Much more important, IMO, is all of the manipulations of $self followed by return {}, $class; (throwing the modified $self away) or that $obj->new() modifies $obj or that 'use strict' only appears in the POD and some serious errors would be caught by its use.

Steve, I'm guessing that the code you were using was a bit different than this (because I don't believe this code will set $width to anything but undef and so won't have much effect). Perhaps you wanted to 'dress it up' more like a complete module before posting it?

The heart of the code looks good and useful. Thanks for posting it. And don't feel too bad about a few mistakes; we all make lots of mistakes.

If you have any questions about the problems I outlined above, please reply and ask them.

- tye        


In reply to Re^2: Breakup user supplied text, whilst correctly ignoring HTML tags. (mini meme) by tye
in thread Breakup user supplied text, whilst correctly ignoring HTML tags. by skx

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.