Sentient Beings,

This is an extension to Hashing it out: defined? exists?. While making these file hashings modular; e.g., get_states(), get_ids(), etc., I am finding that they have the same shell of code, like so: 

sub {
  # get possible args
  # initialize hash
  # open file
  # while file {
    # split
    # possible clean up code
    # hash
  }
  # close file
  # possible counter
  # possible write to log
  # return hash
}

[download]


There are about 15 or so of these. I'm considering creating a versatile sub that can take additional code; something that would be called in this manner: 

get_data(
  pre => undef,
  while => '$_ =~ tr/ / /s;',
  post => 'write_log("Found $count instances");',
);

[download]


  1. Is this a good approach?
  2. If so, would it be better to use eval or do? (or something else?)


Advice appreciated.

Thanks.

In reply to Versatile subs by eff_i_g

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.