my $d = [[],[], [], []];

You don't need to pre-initialise your deep data structures. They'll pop up automagically when you first use them. It's called autovivification. So a

my $d;

should suffice.

Update: To avoid repetitive pushes you could define this function:

sub pushsome { my $AoAref = shift; for (my $i = 0 ; $i <= $#_ ; $i++) { push @{$AoAref->[$i]}, $_[$i]; } }

and then

while ( <DATA> ) { chomp; pushsome $d, split /,/; }

However in this case you need to pre-define $d as an array reference (my $d = [];) ; first-level autovivification can't work through subroutine calls.

Better off IMO is to get rid of the "reference to an array of arrays" ($r) and use an up-front @AoA. Here's your revamped code:

#!/usr/bin/perl use strict; use warnings; use PDL; use PDL::Matrix; sub pushsome { my $AoAref = shift; for (my $i = 0 ; $i <= $#_ ; $i++) { push @{$AoAref->[$i]}, $_[$i]; } } sub fetchdata { my $file = shift; my @AoA; open(DATA, $file) || die "Error: Unable to open $file:$!\n"; while (<DATA>) { chomp; pushsome \@AoA, split /,/; } close DATA; PDL::Matrix->pdl(\@AoA); } # main program @ARGV or die "Please supply a data file on the command line!\n"; my $d = fetchdata( shift ); # ...

In reply to Re: problem with split command by calin
in thread problem with split command by Angharad

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.