Dear Master Monks,

Would you rewrite:

function fileExtension($file) {
        $pos = strrpos($file,".");
        if ($pos == "0") return false;
        else {
                $ext = strtolower(substr($file,$pos));
                return $ext;
        }
}

[download]
As: 
sub fileExtension {
        my $file = shift;
        my $pos = index($file,".");
        if ($pos == "0") {
            return undef;
        } else {
                my $ext = lc(substr($file,$pos));
                return $ext;
        }
}

[download]
Or (as per the Cookbook, File::Basename): 
sub extension {
    my $path = shift;
    my $ext = (fileparse($path,'\.[^.]*'))[2];
    $ext =~ s/^\.//;
    return $ext;
}

[download]

I think the Cookbook is the best.
Gavin.

Walking the road to enlightenment... I found a penguin and a camel on the way.....
Fancy a yourname@perl.me.uk? Just ask!!!

In reply to Rewrite a PHP fileExtension function by ghenry

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.