I second podmaster's onte about
WWW::Mechanize -- it can make code much simpler..
But what i wanted to note is that you could reduce the duplicate code and make maintenance (and use) a little easier by just having one accessor .. (there's many ways to do this -- here's just a quick one)
our KEY_LIST => [ qw/
thumbnailForWebsite
thumbnailForForums1 thumbnailForForums2
hotlinkForForums1 hotlinkForForums2
hotlinkForWebsite
showImage
directLinkToImage
/ ];
sub get {
my $self = shift;
my $key = shift;
# could grep @{&KEY_LIST} here too to check for valid key
return exists $self->{liste}->{$key} ? $self->{liste}->{$key} : unde
+f;
}
# this could be left the same or changed to this:
sub get_all {
my $self = shift;
return { map { $_ => $self->{liste}->{$_} } @{&KEY_LIST} };
}
# note: could also replace get_all() with get() or get('all')
# and note that the loop in upload() becomes just:
foreach( @{&KEY_LIST} ){
...
}
Use of the module then becomes:
print $ih->get('thumbnailForWebsite'), "\n";
print $ih->get('thumbnailForForums1'), "\n";
print $ih->get('thumbnailForForums2'), "\n";
print $ih->get('hotlinkForForums1'), "\n";
print $ih->get('hotlinkForForums2'), "\n";
print $ih->get('hotlinkForWebsite'), "\n";
print $ih->get('showImage'), "\n";
print $ih->get('directLinkToImage'), "\n";
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.