How about something like this for the Manufacturer list?

my(%manufacturers)= ( Cisco => qr/Cisco/i, 'TUT Systems'=> qr/Expresso GS|MDU Lite/i, Gigalink => qr/Gigalink/i, Huawei => qr/Huawei/i, Orinoco => qr/AP-2000|AP-1000/i, Lucent => qr/WavePOINT/i, HP => qr/HP/, Paradyne => qr/Paradyne/i, Colubris => qr/CN320/, SMC => qr/TigerSwitch/, Ricoh => qr/RICOH/, ); $ref->{$host}{$ip}{'manufacturer'}='*unknown*'; while (($manu, $re)= each(%manufacturers)) { if (/$re/) { $ref->{$host}{$ip}{'manufacturer'}=$manu; last; } }
This only works if the sequence of the checks is unimportant. If the sequence does matter, I'd change that to an array:
my(@manufacturers)= ( Cisco => qr/Cisco/i, 'TUT Systems'=> qr/Expresso GS|MDU Lite/i, Gigalink => qr/Gigalink/i, Huawei => qr/Huawei/i, Orinoco => qr/AP-2000|AP-1000/i, Lucent => qr/WavePOINT/i, HP => qr/HP/, Paradyne => qr/Paradyne/i, Colubris => qr/CN320/, SMC => qr/TigerSwitch/, Ricoh => qr/RICOH/, ); $ref->{$host}{$ip}{'manufacturer'}='*unknown*'; $manu= undef; foreach $re (@manufacturers) { if (defined $manu) { if (/$re/) { $ref->{$host}{$ip}{'manufacturer'}=$manu; last; } $manu= undef; } else { $manu= $re; } } print $m;

$\=~s;s*.*;q^|D9JYJ^^qq^\//\\\///^;ex;print

In reply to Re: Maintainable and robust Pattern Matching with changing goalposts by Skeeve
in thread Maintainable and robust Pattern Matching with changing goalposts by McDarren

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.