I would change two things:

First, I would (try to) make the tables parameter optional, defaulting to all tables in the current schema. This is obviously not possible for CSV or some of the other file-based DBDs though.

Second, I'm not sure I like the neccessity of spelling out the whole CREATE TABLE statement when the function call is named create_table as well. Maybe just calling that function do would make me feel better, as changing the SQL string is impossible for CREATE TEMP TABLE...

You could guess the relations between tables from columns with the same name. But then again, that might be too much magic in one place ...


In reply to Re: RFC : Class::DBI::Loader::AnyDBD by Corion
in thread RFC : Class::DBI::Loader::AnyDBD by jZed

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.