Close.
last OUTER;
should be
last OUTER unless $line = <$FH>;
You only want to do it when the end of the file is reached.

Update: Fixed these problems: $FH indicated a file handle but contained a filename, $FH was used as a file handle even though FILE was the file handle, $batch was not initialized, and $line was uselessly checked for "go" twice.

foreach my $filename (@files) { open(my $fh, '<', $filename) or die("Unable to open input file $filename: $!\n"); my $batch = ''; OUTER: while (my $line = <$fh>) { while (not $line =~ m/^\s*go\s*$/i) { $batch .= $line; last OUTER unless $line = <$fh>; } $dbh->do($batch); } }

or without nested loops:

foreach my $filename (@files) { open(my $fh, '<', $filename) or die("Unable to open input file $filename: $!\n"); my $batch = ''; while (my $line = <$fh>) { if (not $line =~ m/^\s*go\s*$/i) { $batch .= $line; next; # Go read next line. } $dbh->do($batch); $batch = ''; } }

In reply to Re^4: ALTER SPROC activation by ikegami
in thread ALTER SPROC activation by Win

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.