An alternative to the join's and building the multiple ?'s is using SQL::Abstract: 
use SQL::Abstract;
my $SA = SQL::Abstract->new;
while (my @row = $dbq->fetchrow_array) {
  my %fields;
  @fields{@fields} = ( $site_hostname, $site_id, @row );   # hash slic
+e to set %fields
  my ($sql, @bind) = $SA->insert( $thisTable, \%fields );
  push @central_insert, [ $sql, \@bind ];
}
...
$dbh->do( $_->[0], {}, @{$_->[1]} ) for @central_insert;

[download]
In this case, you lose the ability to prepare the statement, but in general SQL::Abstract can be very handy... Good example is with dynamic where clauses.

(i'm also not sure why OP needs to queue up the insert's for later and just doesn't do it in the main loop...)

In reply to Re^2: DBI - Handling NULL values by davidrw
in thread DBI - Handling NULL values by McDarren

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.