first comment is that you should use strict; and use warnings; ..next, i think this shortens it up:
#!/usr/bin/perl use strict; use warnings; use Data::Dumper; my $sur = [ { 'one' => 'USA', 'two' => 'GOD', 'three' => '690 +557','four'=>'hello how are u',}, { 'one' => 'USA', 'two' => 'GOD', 'three' => '690 +557','four'=>'I am fine',}, { 'one' => 'UK', 'two' => 'GOD', 'three' => '6905 +58','four'=>'I am Okay',}, ]; my %h; foreach ( @$sur ){ if( exists $h{ $_->{three} } ){ $h{ $_->{three} } .= "####" . $_->{four}; }else{ $h{ $_->{three} } = join "<-->", @{$_}{ qw/one two four/ }; } } print Dumper \%h;
I have to wonder though why @$sur is a hash with those keys instead of just an array ... can you explain where that data structure is coming from/what it's for?

In reply to Re: simplify the code by davidrw
in thread simplify the code by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.