Nor, is it fair that in the 'slow' one, you use a temporary array...

EvanCarroll is right about the slight differences in the routines, so I commented out some things in code and made them both use the same array (note, I increased the number of elements to look for as well as the number of iterations for more meaningful results): 

#!/usr/bin/perl -w
use strict;
use Benchmark qw(:all);

my @choices = qw|a b c z m p t l c f g|;

my %choices = map{$_=>1}@choices;

my @cData = <DATA>;

timethese(50_000,{'Damn Slow'=>\&parseData1,
                'Much Better'=>\&parseData2});

sub parseData1 {
foreach (@cData){
chomp;
my @items = split/,/,$_;
#slow way, 
foreach my $item (@items){
if(grep {$item eq $_} @choices){
   #print qq|FOUND $item|;
 } 
}

}
}

sub parseData2 {
 foreach(@cData){
 chomp;
# foreach my $item (split/,/,$_){
my @items = split/,/,$_;
#slow way, 
foreach my $item (@items){
    if ($choices{$item}){
       #print qq|FOUND $item\n|;
     }
   }
  }

}

__DATA__
z,t,m,u,a,b,c
s,t,l,m,z,a,s
c,b,a,m,u,t,n
k,l,t,s,z,r,t

[download]

Which still produces: 

perl seediff.pl
Benchmark: timing 50000 iterations of Damn Slow, Much Better...
 Damn Slow:  6 wallclock secs ( 6.12 usr +  0.00 sys =  6.12 CPU) @ 81
+72.61/s (n=50000)
Much Better:  3 wallclock secs ( 2.96 usr +  0.00 sys =  2.96 CPU) @ 1
+6874.79/s (n=50000)

[download]

I think the above changes were 'fair' since the performance of a function like SQL in() in an actual database should not decrease noticeably with the number of elements.

Celebrate Intellectual Diversity

In reply to Re^3: Too much SQL not enough perl by InfiniteSilence
in thread Too much SQL not enough perl by jcpunk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.