>That looks great to me, since local will restore the value
>even if handler exits due to an exception (die).

That's what I'd hope, but I feel the need to get the reassurance that it won't fail mysteriously in mod_perl land.

>By the way, you can save yourself some typing by using our.

Right. Two comments.

1. I know about our and tend to use it exclusively these days, but at the time I wrote that code, I was too set in my old-fashioned ways.

2. Although our can save a bit of typing, it also masks the fact that, say, IP_address, *is* global, and I'm not yet convinced that that's always a good idea. At least if someone sees a package identifier at the start of a variable, they know for sure that globals are being used, and can factor in the potential long-range effects of altering those variables. In short, if you're going to be Evil, then it may be a good idea to trumpet the fact, rather than hide it away.

Steve Collyer

In reply to Re^2: mod_perl: globals and security question by scollyer
in thread mod_perl: globals and security question by scollyer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.