Howdy!

A couple of emendations that don't change the essential meaning but do affect whether it works as presented... 

my @work = fetch_jobs($starting_condition);
my %seen;
while ( @work ) {
    # Remove 1 item from our stack/queue
    my $job = shift @work;

    # Skip this job if we have already done it
    next if $seen{$_}++; ## $_ should probably be $job, no?

    # Possibly add new jobs to our stack/queue
    if ( more_jobs($_) ) { ## $_ should probably be $job, no?
        push @work, fetch_jobs($_); ## $_ should probably be $job, no?
    }

    # process job
}

[download]
...because $_ isn't set or otherwise given meaning in this snippet. 

while ( @work || @work < 1000 ) { # should ought to be && not ||
}

[download]
...otherwise the loop will never exit, as an empty @work will always be less than 1000...

yours,
Michael

In reply to Re^6: WWW::Mechanize problem by herveus
in thread WWW::Mechanize problem by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.