In this example, having chosen to sort descending by count, you can take the opportunity to exit the loop as soon as the count drops. I couldn't find any additional tricks that ended up faster other than the fact that apart from that this code was as simply translated from the requirement as I could manage:
my @instances = qw ( AAAAA ATCGA ATAAA ); my @instances2 = qw ( AAAAA AACGA ATAAA ATAAA ); for my $iref ( \@instances, \@instances2 ) { print Concensus( @$iref ) . "\n"; } sub Concensus { my $result = ''; my $length = length( $_[0] ); for (my $i = 0; $i < $length; $i++ ) { my %count = (); for my $input ( @_ ) { $count{ substr( $input, $i, 1 ) }++ } my $winners = ''; my $wincount = 0; for my $try ( sort { $count{ $b } <=> $count{ $a } } keys %cou +nt ) { if ( $wincount ) { ( $count{ $try } == $wincount ) or last; } else { $wincount = $count{ $try }; } $winners .= $try; } ( length( $winners ) > 1 ) and $winners = "[$winners]"; $result .= $winners; } return $result; }

-M

Free your mind


In reply to Re: Finding Consensus String by Moron
in thread Finding Consensus String by monkfan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.