I was reviewing some old code and found this:
foreach $key (keys %form_data) {
my $temp1=$key;
my $temp2=$form_data{$key};
$temp1=~s/([^A-Za-z0-9])/sprintf("%%%02X", ord($1))/seg;
$temp2=~s/([^A-Za-z0-9])/sprintf("%%%02X", ord($1))/seg;
$form_data.=$temp1.'='.$temp2.'&';
}
$form_data=~s/\&$//;
I thought it might be better written as a map, so I came up with this:
$form_data = join('&', map {
s/([^A-Za-z0-9])/sprintf("%%%02X", ord($1)
+)/seg;
$form_data{$_} =~ s/([^A-Za-z0-9])/sprintf
+("%%%02X", ord($1))/seg;
"$_=$form_data{$_}";
} sort keys %form_data);
The map function works as designed and with no complaints, but I was surprised that I could get away with using multiple semi-colon-terminated expressions in it. Is this surprising to anyone else, or just me?
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.